Errore con i tag XmlWriter in gb.xml

[Prokopy]

This is solved in the last revision (#4915).

[sotema]

thanks.

Maybe another problem, maybe i misunderstood the doc:

XmlElement.GetAttribute (gb.xml)
Function GetAttribute ( Name As String ) As String
Returns the attribute Name.

Should return the Value of Attribute "Name"?

With the following code:

Codice: gambas [Seleziona]

Public Sub Main()
Dim oRoot As XmlElement
Dim oDoc As XmlDocument
Dim iVar As Integer
Dim oReader As XmlReader
  oDoc = New XmlDocument
  oDoc.Open("language")
  oRoot = oDoc.Root
  Debug oRoot.Name
  Debug oRoot.Children.Count
  For iVar = 0 To oRoot.ChildElements.Max
    Print oRoot.ChildElements[iVar].GetAttribute("name")
    Print oRoot.ChildElements[iVar].GetAttribute("code")
    Print oRoot.ChildElements[iVar].GetAttribute("region")
  Next
End

i got
name
code
region

while i expect:
Milan
MI
Lombardia

see the attached file.

[Prokopy]

You're right, this should return the value of the attribute. I really hate this kind of stupid bugs...
This is solved in the revision #4917.

[sotema]

Rev #4919 it's ok

[sotema]

Hi Prokopy,
I have a bad new for you.
If you try to read an non existing Attribute a signal 11 occurs. (Rev. #4925)
Use the following code with the file cities attached in my previous post:

Codice: gambas [Seleziona]

Public Sub Main()
Dim oRoot As XmlElement  
Dim oDoc As XmlDocument  
Dim iVar As Integer  
Dim oReader As XmlReader  
 oDoc = New XmlDocument  
 oDoc.Open("cities.txt")  
 oRoot = oDoc.Root  
 Debug oRoot.Name  
 Debug oRoot.Children.Count  
 For iVar = 0 To oRoot.ChildElements.Max  
   Print oRoot.ChildElements[iVar].GetAttribute("name")  
   Print oRoot.ChildElements[iVar].GetAttribute("cod")  ' should be "code"
   Print oRoot.ChildElements[iVar].GetAttribute("region")  
 Next  
    
End

Attached the debugger output.

[Prokopy]

Hum, I think there is a mistake in your code. This line does not crashes :

Codice: gambas [Seleziona]

Print oRoot.ChildElements[iVar].GetAttribute("cod")

... but this one does :

Codice: gambas [Seleziona]

Print oRoot.ChildElements[iVar].Attributes["cod"]

We can see in the debugger output that the CElementAttributes_get method is called, not the CElement_getAttributes one.

Anyway, this is solved in the revision #4927. Thanks.

[sotema]

Hmmm, yes i made some bad cut & paste!

Thanks a lot.

[md9327]

sotema... You are always the same ... 

[sotema]

yep 

[md9327]

I have a small request to make to our friend Procopy.
In the production of an xml file, the XmlWriter (gb.xml and gb.libxml) creates a file with an indentation is not perfectly aligned. The closing tag does not respect the position initiated by the opening tag.
You can make sure to properly align the tags?
Obviously this is just a request you aesthetic ...

Thanks!!!